-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tutorials tab #490
Open
avisil
wants to merge
13
commits into
main
Choose a base branch
from
tutorials-tab
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding tutorials tab #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Sil <43005718+avisil@users.noreply.github.com>
Signed-off-by: Avi Sil <43005718+avisil@users.noreply.github.com>
Signed-off-by: Avi Sil <43005718+avisil@users.noreply.github.com>
added the description Signed-off-by: Avi Sil <43005718+avisil@users.noreply.github.com>
Signed-off-by: Avi Sil <43005718+avisil@users.noreply.github.com>
added re-ranker info to the table. Signed-off-by: Avi Sil <43005718+avisil@users.noreply.github.com>
Signed-off-by: Avi Sil <43005718+avisil@users.noreply.github.com>
Signed-off-by: Avi Sil <43005718+avisil@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Closes #(issue)
Notes:
(issue)
above ↑↑↑ with the issue this PR closes to automatically link the two.This must be done when the PR is created.
Closes #(issue)
as needed.Closes
.Description
Describe the changes proposed by this PR below to give the reviewer context below ↓↓↓
(description)
Request Review
Be sure to request a review from one or more reviewers (unless the PR is to an unprotected branch).
Versioning
When opening a PR to make changes to PrimeQA (i.e.
primeqa/
) master, be sure to increment the version followingsemantic versioning. The VERSION is stored here
and is incremented using
bump2version {patch,minor,major}
as described in the (development guide documentation)[development.html].primeqa
package or was not into master?After pulling in changes from master to an existing PR, ensure the VERSION is updated appropriately.
This may require bumping the version again if it has been previously bumped.
If you're not quite ready yet to post a PR for review, feel free to open a draft PR.
Releases
After Merging
If merging into master and VERSION was updated, after this PR is merged:
Checklist
Review the following and mark as completed: