Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update Node.js to v18 #213

Merged
merged 2 commits into from
Sep 18, 2023
Merged

ci: update Node.js to v18 #213

merged 2 commits into from
Sep 18, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 18, 2023 •
edited
Loading

Closes #212

Update Node.js-related actions to use v18 now that v16 has reached EOL. Also add an nvmrc file with the supported Node.js version for the project.

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 23863e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset Skip the check for changesets label Sep 18, 2023
@joshblack joshblack mentioned this pull request Sep 18, 2023
Closed
@joshblack joshblack marked this pull request as ready for review September 18, 2023 15:57
broccolinisoup
broccolinisoup approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you!

.nvmrc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@joshblack joshblack merged commit 5fc5412 into main Sep 18, 2023
7 checks passed
@joshblack joshblack deleted the ci/update-to-node-18 branch September 18, 2023 21:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees
No one assigned
Labels
skip changeset Skip the check for changesets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Node version on GitHub actions
2 participants
@joshblack @broccolinisoup