MinimalFooter: allow buttons

[stefankp]

We're looking to replace the custom Footer we have on some pages of https://resources.github.com/ with MinimalFooter. To do this, we need the option to allow button as alternative to MinimalFooter.Link.

Example: as you can see at the bottom of https://resources.github.com/enterprise/trial/, we have a button in the footer for "Manage cookies", which opens an overlay to manage cookie settings. The styling should be the same as the text link.

[rezrah]

Potential solution:

Enable as prop of type a | button for MinimalFooter.Link, similar to other polymorphic components in Primer Brand.

[stefankp]

Works for me, but the button wouldn't have the href attribute.

[rezrah]

Works for me, but the button wouldn't have the href attribute.

👍 We'll handle that using conditional types

[JoshBowdenConcepts]

Just to clarify here! Is the intention for this content to be a Button but look like a Link, as you have shown on the Enterprise page?

[stefankp]

@JoshBowdenConcepts exactly. Because it performs an action and doesn't lead to another URL.