-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinimalFooter: allow buttons #264
Comments
Potential solution: Enable |
Works for me, but the |
👍 We'll handle that using conditional types |
Just to clarify here! Is the intention for this content to be a Button but look like a Link, as you have shown on the Enterprise page? |
@JoshBowdenConcepts exactly. Because it performs an action and doesn't lead to another URL. ![]() |
We're looking to replace the custom Footer we have on some pages of https://resources.github.com/ with
MinimalFooter
. To do this, we need the option to allowbutton
as alternative toMinimalFooter.Link
.Example: as you can see at the bottom of https://resources.github.com/enterprise/trial/, we have a button in the footer for "Manage cookies", which opens an overlay to manage cookie settings. The styling should be the same as the text link.
The text was updated successfully, but these errors were encountered: