Added Polymorphic MinimalFooter link #272
Conversation
🦋 Changeset detectedLatest commit: 764477d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
JoshBowdenConcepts
temporarily deployed
to
github-pages
GitHub Actions
Inactive
| </MinimalFooter.Link> | ||
| </MinimalFooter> | ||
| ) | ||
| MaximumLinks.storyName = 'Button Links' |
There was a problem hiding this comment.
This is changing the wrong story, and is presenting like this in Storybook..
Recommend it's removed altogether as it's not any different to the default name.
| MaximumLinks.storyName = 'Button Links' |
There was a problem hiding this comment.
This has been completed in this SHA
|
|
||
| function Link({href, children}: PropsWithChildren<LinkProps>) { | ||
| const Link = <C extends React.ElementType = 'a'>({as, children, ...rest}: PropsWithChildren<LinkProps<C>>) => { | ||
| const Component = as || 'a' |
There was a problem hiding this comment.
Could this be restricted to one of 'a' or 'button'?
There was a problem hiding this comment.
This has been completed in this SHA
| type LinkProps = { | ||
| href: string | ||
| } & BaseProps<HTMLAnchorElement> | ||
| type LinkProps<C extends React.ElementType> = BaseProps<C> & {as?: C} & Omit<React.ComponentPropsWithoutRef<C>, keyof C> |
There was a problem hiding this comment.
Could you update the prop table in docs too please? 🙏
There was a problem hiding this comment.
This has been completed in this SHA
JoshBowdenConcepts
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Nice 👏 |
Summary
We're looking to replace the custom Footer we have on some pages of https://resources.github.com/ with MinimalFooter. To do this, we need the option to allow button as alternative to MinimalFooter.Link.
Example: as you can see at the bottom of https://resources.github.com/enterprise/trial/, we have a button in the footer for "Manage cookies", which opens an overlay to manage cookie settings. The styling should be the same as the text link.
List of notable changes:
What should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist: