-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the layout responsiveness of SubdomainNavBar #644
Improve the layout responsiveness of SubdomainNavBar #644
Conversation
🦋 Changeset detectedLatest commit: c91771b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
4969b61
to
4c4e0ea
Compare
...spec.ts-snapshots/Visual-Comparison-SubdomainNavBar-SubdomainNavBar-Longer-Title-1-linux.png
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @danielguillan 🙌
FYI, the VRT test is failing for one of the stories you mentioned. Let me know if you'd like a hand fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Summary
This pull request improves the layout responsiveness of
SubdomainNavBar
. Fixes #581.🔗 Storybook
List of notable changes:
small
button variant for CTAs.What should reviewers focus on?
Contributor checklist:
Reviewer checklist:
Screenshots: