Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #648

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Release tracking #648

merged 1 commit into from
Jul 22, 2024

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Jul 15, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react-brand@0.35.0

Minor Changes

  • #634 598a2c5d Thanks @joshfarrant! - ⚠️ This update contains a breaking change.

    Refactored VideoPlayer component to make it more modular and customisable.

    • The showTitle prop has been renamed to visuallyHiddenTitle and inverted.
      • This prop hides the title visually, but keeps it accessible to screen readers.
      • Where you previously passed showTitle={false}, you should now pass visuallyHiddenTitle={true}.
    • The branding prop has been renamed to showBranding.
    • Individual video controls can be optionally hidden by setting any of the showPlayPauseButton, showSeekControl, showCCButton, showMuteButton, showVolumeControl, and showFullScreenButton props to false.
    • A custom play icon can be provided using the playIcon prop.

Patch Changes

  • #623 8727997c Thanks @rezrah! - Added fullWidth prop to Hero.Heading to remove default max-width constraint, and enabling easier placement using a parent Grid.

  • #623 8727997c Thanks @rezrah! - Added RiverStoryScroll component, an experimental layout component that wraps around existing River patterns.

    <RiverStoryScroll>
      <River>
        <River.Visual />
        <River.Content />
      </River>
      <River>
        <River.Visual />
        <River.Content />
      </River>
      <River>
        <River.Visual />
        <River.Content />
      </River>
    </RiverStoryScroll>

    🔗 See Storybook for more examples.

  • #647 39e00cfa Thanks @joshfarrant! - Added isExternal prop to SubdomainNavBar.Link component. When isExternal is true, a link-external icon is displayed next to the link.

  • #644 b3f1f364 Thanks @danielguillan! - Improve the layout responsiveness of SubdomainNavBar

  • #639 ebf92224 Thanks @stamat! - Fix cut AnchorNav action button outline due the introduced overflow auto

  • #646 81e983e6 Thanks @rezrah! - Adds responsive toggling of feature lists in the PricingOptions component.

    PricingOptions.FeatureList can now be collapsed at regular and wide viewports.

    <PricingOptions>
      <PricingOptions.Item>
        <PricingOptions.FeatureList expanded={{narrow: true, regular: true, wide: true}} />
      </PricingOptions.Item>
    </PricingOptions>
  • #623 8727997c Thanks @rezrah! - Added --brand-CTABanner-bgColor token to CTABanner for easier customisation of the banners background color, when enabled.

@primer/brand-primitives@0.35.0

Patch Changes

  • #623 8727997c Thanks @rezrah! - Added --brand-CTABanner-bgColor token to CTABanner for easier customisation of the banners background color, when enabled.

@primer/brand-storybook@0.35.0

@primer/brand-e2e@0.35.0

@primer/brand-fonts@0.35.0

@primer/brand-config@0.35.0

Copy link
Contributor

github-actions bot commented Jul 15, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Jul 15, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah
Copy link
Collaborator

rezrah commented Jul 22, 2024

Smoke test results

- RiverStoryScroll 🟢
Works as-expected. Example of plug-and-play support on the Enterprise page

Screen.Recording.2024-07-22.at.10.57.32.mov

- Pricing options 🟢
Works as-expected in dotcom and githubuniverse.com. The latter required rolling back a lot of local workarounds to achieve a similar effect:

Screen.Recording.2024-07-22.at.11.23.29.mov

- SubdomainNavBar isExternal prop 🟢
Works as-expected in Universe, but the site employs a number of workarounds that aren't compatible with this release. As these are user-side, and given Storybook is rendering correctly this is not a blocker for the release.. cc. @simurai

Screenshot 2024-07-22 at 11 09 01

Screenshot 2024-07-22 at 11 03 46

- VideoPlayer refactor 🟡

Works as expected, but noted a few minor issues that can be rectified in a future patch update

  • Focus outline issue:
    Screenshot 2024-07-22 at 10 49 01

Working on Copilot page:
Screenshot 2024-07-22 at 10 48 51

- AnchorNav overflow update on narrow viewports 🟢

Works as expected, focus ring no longer obstructed
Screenshot 2024-07-22 at 10 49 58

Release testing status: Ready to release 🟢

@rezrah rezrah merged commit c542955 into main Jul 22, 2024
18 checks passed
@rezrah rezrah deleted the changeset-release/main branch July 22, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants