Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README updates #350

Merged
merged 15 commits into from Nov 16, 2018
Merged

README updates #350

merged 15 commits into from Nov 16, 2018

Conversation

emplums
Copy link

@emplums emplums commented Nov 6, 2018 •
edited

Updates to our README!

  • Removed unnecessary docs
  • Added a section about our documentation website
  • @ashygee made a new thumbnail! (planning on iterating on this further)
  • Added a bunch of badges 馃檶

@vercel
Copy link

vercel bot commented Nov 6, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

emplums
emplums commented Nov 6, 2018
View reviewed changes
README.md Show resolved Hide resolved
emplums
emplums commented Nov 6, 2018
View reviewed changes
README.md Show resolved Hide resolved
emplums
emplums commented Nov 6, 2018
View reviewed changes
README.md Show resolved Hide resolved
@emplums emplums changed the base branch from master to q4-cool-zoo November 8, 2018 04:35
shawnbot
shawnbot reviewed Nov 8, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
shawnbot and others added 2 commits November 8, 2018 15:36
@shawnbot
wip wording
1e7408a 
Co-Authored-By: emplums <emplums@github.com>
use centered template from primer.style
8fa406a
@ashygee
Copy link
Contributor

ashygee commented Nov 15, 2018

@emplums Here's the README image for this first version

readme-v1

@emplums emplums changed the title WIP README updates README updates Nov 16, 2018
shawnbot
shawnbot reviewed Nov 16, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
shawnbot
shawnbot approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had just one suggestion to add "the" in the graf about Primer CSS, but otherwise looks great! Thanks for this.

@shawnbot
Update README.md
3615b63 
Co-Authored-By: emplums <emplums@github.com>
@emplums emplums merged commit 3c950d0 into q4-cool-zoo Nov 16, 2018
@emplums emplums deleted the pretty-readme branch November 16, 2018 17:59
@emplums emplums mentioned this pull request Nov 16, 2018
Merged
12 tasks
@ashygee ashygee mentioned this pull request Nov 26, 2018
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emplums @ashygee @shawnbot