Skip to content

Commit

Permalink
Make sure to apply backdrops only to one Overlay (#2249)
Browse files Browse the repository at this point in the history
* Make sure to apply backdrops only to one Overlay

* Update overlay.scss

* Create stale-drinks-arrive.md

* Update stale-drinks-arrive.md

Co-authored-by: Katie Langerman <langermank@github.com>
Co-authored-by: Josep Martins <josepmartins@github.com>
  • Loading branch information
3 people committed Sep 15, 2022
1 parent 26aea66 commit 8108377
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .changeset/stale-drinks-arrive.md
@@ -0,0 +1,6 @@
---
"@primer/css": patch
---

Increase specificy for Overlay styles as they relate to the backdrop and positioning options
- If a Dialog opens a second Dialog, each Dialog properties should be contained to its own scope
8 changes: 4 additions & 4 deletions src/overlay/overlay.scss
Expand Up @@ -345,7 +345,7 @@ $primer-borderRadius-large: 0.75rem;
align-items: center;
justify-content: left;

.Overlay#{$responsiveVariant} {
> .Overlay#{$responsiveVariant} {
height: 100vh;
max-height: unset;
border-radius: $primer-borderRadius-large;
Expand All @@ -362,7 +362,7 @@ $primer-borderRadius-large: 0.75rem;
align-items: center;
justify-content: right;

.Overlay#{$responsiveVariant} {
> .Overlay#{$responsiveVariant} {
height: 100vh;
max-height: unset;
border-radius: $primer-borderRadius-large;
Expand All @@ -379,7 +379,7 @@ $primer-borderRadius-large: 0.75rem;
align-items: end;
justify-content: center;

.Overlay#{$responsiveVariant} {
> .Overlay#{$responsiveVariant} {
width: 100vw;
height: auto;
max-height: calc(100vh - 2rem);
Expand All @@ -397,7 +397,7 @@ $primer-borderRadius-large: 0.75rem;
align-items: start;
justify-content: center;

.Overlay#{$responsiveVariant} {
> .Overlay#{$responsiveVariant} {
border-radius: $primer-borderRadius-large;
border-top-left-radius: 0;
border-top-right-radius: 0;
Expand Down

0 comments on commit 8108377

Please sign in to comment.