Tracking issue for Primer v10

[broccolini]

Planning to ship Primer v10 in the next couple of weeks, tracking what we'd like to include:

Must

• Figure out what deprecating modules looks like - @jonrohan, and deprecate following modules:
  • Deprecate marketing cards module Deprecating primer-cards and form-cards #379
  • Deprecate credit cards from forms module Deprecating primer-cards and form-cards #379
• Ship Primer Storybook - @broccolini Primer Storybook #318
• Import new modules (see https://github.com/github/styleguide/issues/160 for tracking issue):
  • dropdown => v10.1.0
  • branch-name - @shawnbot Import branch-name component from github/github #341
  • Subhead - @shawnbot Import Subhead component #342
  • input groups - @shawnbot [WIP] Import input groups #344
  • Add underline nav component (new) - @ampinsk Refactor underline nav #377
• Update primer.io site - @broccolini (this is a temporary update until the new docs site is published) Update primercss.io website #315
• Tooltips update delay => v10.1.0
• Tooltips: fix disconnected caret and darken color opacity => v10.1.0
• Move primer-breadcrumbs into primer-core @jonrohan
• Update github.com with v10 - @jonrohan https://github.com/github/github/pull/80630
• Update style guide with v10 - @broccolini
• Update website starter with v10

Should

• Move stylelint module into the monorepo - @shawnbot
• Button border radius fix Button border-radius fix #388 - @broccolini
• Marketing buttons - @gladwearefriends 🎉 w/ @shawnbot Add marketing buttons to primer-marketing-buttons #337
• remove -webkit-text-decoration-skip override remove -webkit-text-decoration-skip override #320
• Change markdown li break to handle Safari 10.x user stylesheet bug Change markdown li break to handle Safari 10.x user stylesheet bug #359

Could

• Add new popover component https://github.com/github/design-systems/issues/411 - @brandonrosage
• New utilities and docs - @sophshep New utilities & docs - fade out, hover grow, border white fade, responsive positioning, and circle #375
• Remove before/after padding markdown hack Removing ::before ::after padding hack on markdown #360 - @jonrohan
• Update to breadcrumb component => v10.1.0
• Update changelog format to match lerna's https://github.com/lerna/lerna/releases/tag/v2.5.0
• Fix script to always publish alpha release, unless it's a rc or a release

cc @primer/design-systems

[shawnbot]

We have a release branch for v10! Here's a proposed plan for managing 9.x changes until we release and merge v10 back to dev:

1. PRs for 9.x should still be filed against dev.
2. 10.x changes should merge into release-10.0.0.
3. If necessary, we can cherry-pick individual merged commits from dev to the v10 release branch.
   • ⚠️ If we do that, we'll need to avoid or revert any changes to version fields in package.json that might unintentionally undo v10 version bumps.

[broccolini]

@shawnbot Just to clarify no. 2. Were you thinking we would branch off of release-10.0.0 or branch off dev and merge into release-10.0.0? There's a couple of in-progress pr's started before this branch, such as the storybook branch but I think we can wrap those up and merge into release-10.0.0 soon. I'm more familiar with the octopus pr approach which would mean all our updates would be branched off `release-10.0.0, reviewed and approved and then merged back in. I think that keeps that branch history cleaner and means in our individual pr's we're testing against all the other changes.

Another thing I was thinking, if I get primer storybook ready it might be good to merge that into release-10.0.0 because it would be handy for testing the updates and additions of new components with and a good way for more of us to test using it.

[shawnbot]

Yeah, to clarify: future changes for v10 should branch off release-10.0.0. I'm pretty sure that most, if not all, of the WIP PRs can just have their base changed and work fine as-is. It's the ones that have changes to package.jsons that we'll need to watch out for. I'm no git expert, but changing the base shouldn't muck up the commit history too badly. @jonrohan, do you have any thoughts?

And big 👍 to making Storybook part of the v10 release!

[broccolini]

New http://primercss.io/ is live 🎉

[broccolini]

@califa @brandonrosage @ampinsk @gladwearefriends @sophshep
Here's a basic outline of what you need to do to test, real docs coming soon!

1. Make changes in Primer against the dev branch
2. Test in Storybook by running npm start, you'll need to add a story if there isn't already
3. When you're happy with the changes you'll need to test in GitHub: make a new branch in github/github, then run bin/npm install primer-css@<your-alpha-release> twice, yes, twice!
4. At this point you can test locally and make more changes in Primer and repeat step 3 again. If you're happy with your changes, commit your changes, open a pr and deploy to review lab for testing.
5. If you need to make markup changes in github/github go ahead and do this now and ping @design-systems for review when you're ready.

If you need to test changes in the style guide:

1. clone the style guide and run script/bootstrap to install all the things
2. make a new branch and install your alpha release with npm install --save --save-exact primer-css@<your-alpha-release>, then run npm run update-deps,
3. to run the style guide locally and test your changes, run npm start, (hit ctrl+C to stop the server)
4. if you want to deploy your branch to share with others, push up your changes and open a pr, join the #design-ops channel and ask hubot to deploy to staging with .deploy styleguide/your-branch to staging

[jonrohan]

twice, yes, twice!

twice so nice 🍦

[broccolini]

This shipped! #354