Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 10.0.0 #354

Merged
merged 235 commits into from
Nov 14, 2017
Merged

Release 10.0.0 #354

merged 235 commits into from
Nov 14, 2017

Conversation

broccolini
Copy link
Member

@broccolini broccolini commented Sep 25, 2017

WIP pr for Primer X release 😎

Tracking issue here: #335

Note: Any v10 work should be merged into this branch once it's ready and approved, but to get an alpha release for testing you'll need to make the base branch dev temporarily.

Ship checklist

  • Update changelog
  • Add new release
  • npm run bump
  • Update primer.io to point to v10
  • Publish updated storybook

astorije and others added 30 commits August 12, 2017 20:53
As far as I understand (the git history is not too easy to follow on this repo :/), when `tooltipped-no-delay` was added, there were no animations/transitions on the tooltip.

This commit removes the delay, so that the transition starts immediately, instead of suppressing the transition entirely. It effectively makes the 2 variants differ by only the initial delay (like the name suggests).
This adds a regex for documentation that essentially assumes ERB helpers
like `<%= octicon("x") %>` will generate an element with the `octicon`
class. cc @jonrohan
Do not suppress opacity transition for tooltipped-no-delay
Import branch-name component from github/github

```html
<span class="anim-fade-out"><%= octicon("mark-github", :height => 32, :class => "v-align-middle mr-2") %> Hello from GitHub!</span>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ``` here

@broccolini
Copy link
Member Author

broccolini commented Nov 12, 2017

Noticed some issues that need fixing here after testing in the style guide on staging:

  • hover-grow: add margin on example so can see the animation
  • fade-out syntax still looks incorrect on staging but is correct in rendered readme
  • input-group: forms page needs {toc:}

@broccolini broccolini changed the title [WIP] Release 10.0.0 Release 10.0.0 Nov 13, 2017
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Win!!

 - primer-alerts@1.5.2
 - primer-avatars@1.4.2
 - primer-base@1.6.0
 - primer-blankslate@1.4.2
 - primer-box@2.5.2
 - primer-branch-name@1.0.0
 - primer-breadcrumb@1.4.2
 - primer-buttons@2.5.0
 - primer-core@6.5.0
 - primer-forms@2.0.0
 - primer-labels@1.5.2
 - primer-layout@1.4.2
 - primer-markdown@3.7.2
 - primer-marketing-buttons@1.0.0
 - primer-marketing-support@1.3.2
 - primer-marketing-type@1.4.2
 - primer-marketing-utilities@1.5.0
 - primer-marketing@6.0.0
 - primer-navigation@1.5.0
 - primer-page-headers@1.4.2
 - primer-page-sections@1.4.2
 - primer-popover@0.0.2
 - primer-product@5.5.0
 - primer-subhead@1.0.0
 - primer-support@4.4.2
 - primer-table-object@1.4.2
 - primer-tables@1.4.2
 - primer-tooltips@1.4.2
 - primer-truncate@1.4.2
 - primer-utilities@4.8.2
 - primer@10.0.0
 - generator-primer-module@1.0.1
 - stylelint-config-primer@2.2.1
 - stylelint-selector-no-utility@1.8.1
@broccolini broccolini merged commit 1c44bfa into master Nov 14, 2017
@jonrohan jonrohan mentioned this pull request Nov 14, 2017
5 tasks
@broccolini broccolini mentioned this pull request Jan 18, 2018
28 tasks
@jonrohan jonrohan deleted the release-10.0.0 branch June 13, 2018 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet