Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unordered list not correctly indented #4

Closed
ghost opened this issue Mar 23, 2015 · 2 comments
Closed

Unordered list not correctly indented #4

ghost opened this issue Mar 23, 2015 · 2 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Mar 23, 2015

As seen on http://primercss.io/type/#unordered, the unordered list is not indented correctly.

screen shot 2015-03-23 at 12 51 21 pm

The following (located in docs.scss) overrides .markdown-body ul and removes all padding:

.docs-example ul {
    padding: 0;
    margin-left: 0;
    margin-right: 0;
}
.markdown-body ul, 
.markdown-body ol {
    padding-left: 2em;
}

Removing the padding on .docs-example ul yields:
screen shot 2015-03-23 at 12 51 14 pm

@mdo mdo added this to the v2.0.3 milestone Mar 23, 2015
@mdo mdo added bug labels Mar 23, 2015
@mdo mdo self-assigned this Mar 23, 2015
@ghost ghost mentioned this issue Mar 24, 2015
@mdo mdo removed the bug label Mar 28, 2015
@mdo
Copy link
Contributor

mdo commented Mar 28, 2015

Ah, upon further inspection, this isn't a but. It's how Primer handles these lists, though I agree it's less than ideal. We'll be removing it come v3.

@mdo
Copy link
Contributor

mdo commented Mar 28, 2015

Docs notes added in #4.

@mdo mdo closed this as completed Mar 28, 2015
shawnbot pushed a commit that referenced this issue Oct 9, 2017
jonrohan added a commit that referenced this issue Oct 9, 2017
Update primer-utilities to version 1.0.0 🚀
emilybrick pushed a commit that referenced this issue Oct 4, 2018
Alias /components to primer-react-dev for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant