Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove negative zero margin utilities #472

Closed
shawnbot opened this issue Apr 21, 2018 · 0 comments
Closed

Remove negative zero margin utilities #472

shawnbot opened this issue Apr 21, 2018 · 0 comments

Comments

@shawnbot
Copy link
Contributor

Our SCSS generates negative margin utility classes for all of our spacer values, including zero. This means that we've got 20 (top, right, bottom, left, and then four responsive variants for each edge) classes that nobody should use in our CSS. The class declarations here and here should probably be skipped when $size is zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant