Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primer-module-build devDependencies.primer-utilities is not updated automatically #504

Closed
shawnbot opened this issue Jun 19, 2018 · 1 comment

Comments

@shawnbot
Copy link
Contributor

After updating primer-utilities with npm run bump in #502, the CI build failed trying to publish primer-module-build in script/release-candidate. I suspect that it's because the devDependencies.primer-utilities field in its package.json wasn't updated by the bump script (that is, by Lerna) because it still listed 4.9.0, while the bumped version was 4.11.1. When I updated the version manually in 08bd474, the build succeeded.

Until we track this down, we might either need to update primer-module-build manually whenever the version of primer-utilities increments or try moving primer-utilities from devDependencies to dependencies to see if Lerna updates it correctly.

@shawnbot
Copy link
Contributor Author

This is no longer an issue as of #671. primer-module-build is officially deprecated! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant