Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding stateful button from .com #535

Closed
jonrohan opened this issue Jul 6, 2018 · 2 comments
Closed

Adding stateful button from .com #535

jonrohan opened this issue Jul 6, 2018 · 2 comments
Labels
css minor release status: help wanted 💝

Comments

@jonrohan
Copy link
Member

jonrohan commented Jul 6, 2018

Is your feature request related to a problem? Please describe.
We have some action buttons on the site follow, watch, star that could use some statefulness so that they show what someone has done, and on hover what they can do.

Additional context
In github/github we have the start of some stateful buttons https://github.com/github/github/pull/92917/files#diff-d4ef900042f8beeed4380882ec19c0c9 After some testing these should be pulled into primer.

re https://github.com/github/design-systems/issues/85
@koddsson
Copy link
Contributor

@jonrohan I can't find that buttons.scss file anymore. Looks like we've might have upstreamed any changes we wanted to do already?

@jonrohan
Copy link
Member Author

Maybe so, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css minor release status: help wanted 💝
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonrohan @shawnbot @yaili @koddsson