Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout is not fixed #77

Closed
gam-phon opened this issue Mar 30, 2015 · 1 comment
Closed

layout is not fixed #77

gam-phon opened this issue Mar 30, 2015 · 1 comment

Comments

@gam-phon
Copy link

layout is not fixed. for example:

<div class="columns">
        <div class="four-fifths column">
           <!-- header -->
        </div>
        <div class="one-fifth column">
            <!-- account -->
        </div>
</div>

When there is no contents in then will be on the left not on the right

@mdo
Copy link
Contributor

mdo commented Mar 30, 2015

Yes, there is no min-height or anything like that to ensure an empty <div> doesn't collapse. We have no plans to add that to Primer either—Bootstrap has it though—since all our columns are essentially guaranteed to have content in them.

I'd suggest that if you have no content within the column, you simply remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants