Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate BlinkMacSystemFont in favor of system-ui #838

Closed
shawnbot opened this issue Jul 17, 2019 · 2 comments
Closed

Deprecate BlinkMacSystemFont in favor of system-ui #838

shawnbot opened this issue Jul 17, 2019 · 2 comments

Comments

@shawnbot
Copy link
Contributor

shawnbot commented Jul 17, 2019

This issue has a storied history, as documented by @jonathantneal in this comment. Here's the status of system-ui as of this issue's creation, as culled form caniuse.com and chromestatus.com:

Browser Font name Status
Chrome system-ui shipped in Chrome 56 (c. 2017)
Safari system-ui shipped in Safari 11 (c. 2017)
Firefox -apple-system ✅shipped in Firefox 43 (c. 2015)
Firefox system-ui 🗣 "public support" (but no intent to implement)
Edge -apple-system ✖️No public signals
Edge system-ui ✖️No public signals

Given the above status, I would suggest replacing BlinkMacSystemFont with system-ui, -apple-system. Edge doesn't support any of those, so it will continue to fall back on sans-serif.

@broccolini started this process in #408, but that PR is really old, and @mdo had some concerns about the appearance of some Linux system fonts. We have some long-running issues with type on Linux, so I'd like to look at what other frameworks have done before we make a final decision and move forward with the change.

@shawnbot shawnbot added this to Release backlog in 📦 Primer CSS release tracking Jul 26, 2019
sindresorhus added a commit to sindresorhus/modern-normalize that referenced this issue Dec 23, 2019
@simurai simurai added this to 📮 Inbox in 🐞 Primer CSS issue tracking via automation Dec 30, 2019
@simurai simurai moved this from 📮 Inbox to 🐕 Medium priority in 🐞 Primer CSS issue tracking Dec 30, 2019
@simurai
Copy link
Contributor

simurai commented Jan 7, 2021

If this comes up again, system-ui seems to have a problem with Simplified Chinese. See article and article. But that could also be outdated by now?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label Jul 6, 2021
🐞 Primer CSS issue tracking automation moved this from 🐕 Medium priority to 💜 Done Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major release Stale Automatically marked as stale. status: investigate
Projects
No open projects
Development

No branches or pull requests

2 participants