Make brand-blue AA compliant #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,7 @@ $container-width: 980px !default; | |||
| $grid-gutter: 10px !default; | |||
|
|
|||
| // Brand colors | |||
| $brand-blue: #4183c4 !default; | |||
| $brand-blue: #4078C0 !default; | |||
There was a problem hiding this comment.
Color #4078C0 should be written as #4078c0
|
👍 I think the extra saturation looks nicer in general. Links looks good as well.
|
|
👍 👍 🤘 |
|
👍 |
1 similar comment
|
👍 |
|
Hell yeah. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brand blue was failing colour contrast checks. As referenced in https://github.com/github/github/issues/40219.
The new blue is now AA complaint and AAA complaint over 18pt.