Add .bg-orange to the list of colors #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * https://primer.style/css/utilities/colors#background-utilities mentions `.bg-orange` as an accessibility approved background color. However, the `src/utilities/colors.scss` file did not have this class listed. This change addresses the need by: * Adding `.bg-orange` to `src/utilities/colors.scss`.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/nxa4ilbfy |
simurai
approved these changes
Aug 2, 2020
simurai
added this to 🔍 Ready to release
in 📦 Primer CSS release tracking
via automation
simurai
moved this from 🔍 Ready to release
to ✅ Approved for release
in 📦 Primer CSS release tracking
📦 Primer CSS release tracking
automation
moved this from ✅ Approved for release
to 💜 Done
Aug 3, 2020
|
@garman FYI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bg-orangeclass that is associated with$orange-700->#d15704Why:
mentions
.bg-orangeas an accessibility approved background color.However, the
src/utilities/colors.scssfile did not have this classlisted.
This change addresses the need by:
.bg-orangetosrc/utilities/colors.scss./cc @primer/ds-core