Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌗 Color Modes #1134

Closed
wants to merge 1 commit into from
Closed

🌗 Color Modes #1134

wants to merge 1 commit into from

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Aug 3, 2020

⚠️ Don't merge this into master just yet. It will most likely be released as Primer CSS 16.0.0. ⚠️

This PR is only to test changes with a different package name (@primer/css-next) so it can be installed in parallel to @primer/css.

🔍 All PRs merged into color-modes (so far).

How to use this branch

  1. Make a PR and change the base branch to color-modes
    • You might wanna branch off from color-modes if your changes are related.
  2. When the PR is approved, merge it
  3. In dotcom run bin/npm install @primer/css-next@canary
    • Or e.g. bin/npm install @primer/css-next@0.0.0-4467910 if you want to rollback to a previous PR

How to release this branch

Once all the changes from color-modes should be available in @primer/css, do the following:

  1. Revert this commit 0ffe77a (renaming the package)
  2. Create a new "release" branch, probably release-16.0.0.
  3. Change the base branch for this PR to release-16.0.0 -> merge it.
  4. Follow the usual RELEASING process.

@vercel
Copy link

vercel bot commented Aug 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/3uyghujb2
✅ Preview: https://primer-css-git-color-modes.primer.vercel.app

@simurai simurai added this to 🔍 Ready to release in 📦 Primer CSS release tracking via automation Aug 3, 2020
@simurai simurai moved this from 🔍 Ready to release to 🚧 Work in Progress in 📦 Primer CSS release tracking Aug 3, 2020
@simurai simurai mentioned this pull request Aug 3, 2020
18 tasks
@simurai
Copy link
Contributor Author

simurai commented Sep 10, 2020

Let's keep #1131 as the "long running" branch. Just one big PR might be fine for now and we don't have to go hunt through many smaller PRs.

@simurai simurai closed this Sep 10, 2020
📦 Primer CSS release tracking automation moved this from 🚧 Work in Progress to 💜 Done Sep 10, 2020
@jonrohan jonrohan deleted the color-modes branch March 26, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant