Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing rounded-3 utility #1156

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Conversation

esdraspavon
Copy link
Contributor

@esdraspavon esdraspavon commented Sep 2, 2020

Closes #1154

/cc @primer/ds-core

@vercel vercel bot temporarily deployed to Preview September 2, 2020 22:22 Inactive
@vercel
Copy link

vercel bot commented Sep 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/aqcneijd4
✅ Preview: https://primer-css-git-fork-esdraspavon-fix-rounded.primer.vercel.app

@simurai simurai added this to 🔍 Ready to release in 📦 Primer CSS release tracking via automation Sep 3, 2020
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@esdraspavon Thanks for the addition. 🙇

Just realized we also have utility classes for each edge:

.rounded#{$variant}-#{$edge}-1 {
@each $corner in $corners {
border-#{$corner}-radius: $border-radius / 2 !important;
}
}
.rounded#{$variant}-#{$edge}-2 {
@each $corner in $corners {
border-#{$corner}-radius: $border-radius !important;
}
}
.rounded#{$variant}-#{$edge}-3 {
@each $corner in $corners {
border-#{$corner}-radius: $border-radius * 2 !important;
}
}

Maybe we should use the $border-radius-[1-3] variables too instead of / 2 and * 2 so the values match?

@simurai simurai moved this from 🔍 Ready to release to 🚧 Work in Progress in 📦 Primer CSS release tracking Sep 3, 2020
@simurai simurai changed the title rounded-3 added Add missing rounded-3 utility Sep 3, 2020
@esdraspavon
Copy link
Contributor Author

@simurai np! sounds good to me!

@vercel vercel bot temporarily deployed to Preview September 3, 2020 12:48 Inactive
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thanks 🙇

📦 Primer CSS release tracking automation moved this from 🚧 Work in Progress to ✅ Approved for release Sep 4, 2020
@simurai simurai changed the base branch from master to release-15.2.0 September 8, 2020 04:22
@simurai simurai merged commit c8132e6 into primer:release-15.2.0 Sep 8, 2020
📦 Primer CSS release tracking automation moved this from ✅ Approved for release to 💜 Done Sep 8, 2020
@simurai simurai mentioned this pull request Sep 10, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

.rounded-3 is missing
2 participants