Update scss-lint properties for v0.38.0 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We’ve updated our scss_lint gem to the latest version, and this required us to update some of the properties here. We also added and turned off new ones. This pull updates the config to keep in line with the rest of our codebase.
|
Is the (re?)addition of the |
yes our ci setup treats them all as warnings if it's not specified. |
|
👍 Cool, thx. |
These are taken care of by autoprefixer right @mdo?
|
|
||
| h4 + p.note { | ||
| margin-top: 0; | ||
| + p.note { |
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
It doesn't look like we can have warnings turned on for @houndci They don’t treat them differently from errors. :(
|
Are all those Hound checks good to go then? |
yeah ignore those. |
mdo
added a commit
that referenced
this pull request
Jun 1, 2015
Update scss-lint properties for v0.38.0
Closed
timv88
pushed a commit
to timv88/primer
that referenced
this pull request
Aug 12, 2015
…one_is_enter_my_name_Thrillhouse Combining $codeFont and $monoFont
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’ve updated our scss_lint gem to the latest version, and this
required us to update some of the properties here. We also added and
turned off new ones.
This pull updates the config to keep in line with the rest of our
codebase.
@mdo @primer/owners