Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds flex-shrink: 0 to .avatar class #1183

Merged
merged 3 commits into from Mar 11, 2021
Merged

Conversation

colinkeany
Copy link
Contributor

This PR adds flex-shrink: 0 by default to all avatars to prevent avatars being squished down when resizing the browser.

Addresses: https://github.com/github/design-systems/issues/1028

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Oct 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/YB3fAwCuotmxDhFZaq7m6XUKzp9B
✅ Preview: https://primer-css-git-avatar-flex-shrink-0-primer.vercel.app

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢👍

@simurai simurai added this to 🔍 Ready to release in 📦 Primer CSS release tracking via automation Oct 5, 2020
@simurai simurai moved this from 🔍 Ready to release to ✅ Approved for release in 📦 Primer CSS release tracking Oct 5, 2020
@vercel vercel bot temporarily deployed to Preview October 7, 2020 18:54 Inactive
@simurai simurai changed the base branch from master to release-16.0.0 March 11, 2021 07:45
@vercel vercel bot temporarily deployed to Preview March 11, 2021 07:47 Inactive
@simurai simurai merged commit 873c0d1 into release-16.0.0 Mar 11, 2021
📦 Primer CSS release tracking automation moved this from ✅ Approved for release to 💜 Done Mar 11, 2021
@simurai simurai deleted the avatar-flex-shrink-0 branch March 11, 2021 07:49
@simurai simurai mentioned this pull request Mar 11, 2021
16 tasks
@github-actions github-actions bot mentioned this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants