-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: color modes docs #1186
Merged
Merged
WIP: color modes docs #1186
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
f521e18
WIP: color modes docs
BinaryMuse fb8a46b
Merge branch 'mkt/color-modes-whee' into mkt/color-modes-docs
BinaryMuse ea3d15d
Update color mode mixin to support 'auto'
BinaryMuse 0046e6d
Merge branch 'mkt/color-modes-whee' into mkt/color-modes-docs
BinaryMuse 024bc21
docs wip
BinaryMuse 18a30ac
Merge branch 'mkt/color-modes-docs' of github.com:primer/css into mkt…
BinaryMuse fd9a308
Merge remote-tracking branch 'origin/mkt/color-modes-whee' into mkt/c…
BinaryMuse eca4322
Make color mode toggle global
BinaryMuse 8397fbc
Merge remote-tracking branch 'origin/mkt/color-modes-whee' into mkt/c…
BinaryMuse d332a33
Tweak global color mode toggle
BinaryMuse 369ff1d
Why is this still here
BinaryMuse 8fd49df
:fire: console.log
BinaryMuse d5c7f6a
Move CustomEvent to runtime only
BinaryMuse 5711c3a
Merge branch 'mkt/color-modes-whee' into mkt/color-modes-docs
BinaryMuse a24bbd1
Flesh out color system, add (temporary) migration guide doc
BinaryMuse 6e0a06d
Merge remote-tracking branch 'origin/mkt/color-modes-whee' into mkt/c…
BinaryMuse f41b615
Fix bad URL
BinaryMuse dbc1d69
Remove workflow guide
BinaryMuse 2698079
Merge remote-tracking branch 'origin/mkt/color-modes-whee' into mkt/c…
BinaryMuse 6da07ec
Tweaks to color system page
BinaryMuse b97d401
Update migration guide
BinaryMuse f7d9c56
Fixup links from .md file
BinaryMuse c4a5d72
Re-enable variable analysis
BinaryMuse b771edf
Update Octicon import
BinaryMuse 5c95623
Re-enable variables page
BinaryMuse 2a0a427
Merge remote-tracking branch 'origin/master' into mkt/color-modes-docs
BinaryMuse 82ac274
Merge remote-tracking branch 'origin/mkt/color-modes-whee' into mkt/c…
BinaryMuse ed44b6e
Update link to Primer Primitives docs
BinaryMuse b9e538a
Remove docs that were moved to external migration guide
BinaryMuse a3fb1f7
Reintroduce variable parsing for border colors
BinaryMuse 9a36754
Default to variable name when parsing vars
BinaryMuse 7f7ca98
Update migration guide
simurai 0826721
Merge branch 'mkt/color-modes-whee' into mkt/color-modes-docs
BinaryMuse 728e480
Merge branch 'mkt/color-modes-whee' into mkt/color-modes-docs
BinaryMuse 1667991
Merge branch 'mkt/color-modes-whee' into mkt/color-modes-docs
BinaryMuse 1441170
Merge branch 'mkt/color-modes-whee' into mkt/color-modes-docs
BinaryMuse File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: move
capitalize
to CSSThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this make
state-hoverPrimaryBg
intostate-hover-primary-bg
? That would be nice for copy&pasta.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the kebabCase function from lodash to convert
hoverPrimerBg
tohover-primer-bg
in https://primer.style/primitives