Prepend monospace font stack with new ui-monospace font family #1219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the monospace font stack used
SFMono-Regular
, which would only work when the user had both manually installed SF Mono and was using Chrome. With this PR, the browser will choose the system font’s monospace variant, given that the browser actually supportsui-monospace
. Browser support is, as of this PR, limited to Safari. It can’t hurt to add, though. Support will hopefully expand to other browsers asui-monospace
is part of the CSS Fonts Module Level 4 Draft./cc @primer/ds-core