Move marketing @font-face declarations from vars to type #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/D6AVyYPKpvxFKSYZu6PccoyyVDEJ |
skullface
approved these changes
Mar 9, 2021
|
Makes sense to me! ✅ |
simurai
added this to 🔍 Ready to release
in 📦 Primer CSS release tracking
via automation
simurai
moved this from 🔍 Ready to release
to ✅ Approved for release
in 📦 Primer CSS release tracking
📦 Primer CSS release tracking
automation
moved this from ✅ Approved for release
to 💜 Done
Mar 11, 2021
Merged
This was referenced Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all the marketing
@font-facedeclarations frommarketing/support/variables.scsstomarketing/type/typography.scss. Since variables can be expected to be imported multiple times in another bundle, having anything other than variables invariables.scssrisks introducing duplication of styles./cc @primer/ds-core