Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link color inherit on :hover #1294

Merged
merged 6 commits into from Apr 5, 2021
Merged

Link color inherit on :hover #1294

merged 6 commits into from Apr 5, 2021

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Apr 2, 2021

This adds a hack from github that we use to allow us to put a color utility inside of a Link class and when the link is hovered the whole link turns the predicable link hover color.

We'll need to remove from hacks when this is added to a release.

/cc @primer/ds-core

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2021

🦋 Changeset detected

Latest commit: 734ac58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/BNdqYLF9B3sizMaQU8fdKGmz53bY
✅ Preview: https://primer-css-git-linkcolorinherit-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview April 2, 2021 03:42 Inactive
@vercel vercel bot temporarily deployed to Preview April 2, 2021 17:36 Inactive
@vercel vercel bot temporarily deployed to Preview April 2, 2021 18:46 Inactive
@vercel vercel bot temporarily deployed to Preview April 5, 2021 07:24 Inactive
@simurai simurai merged commit 7a29f79 into main Apr 5, 2021
@simurai simurai deleted the link_color_inherit branch April 5, 2021 07:37
@primer-css primer-css mentioned this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants