Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dividers and allow sidebar positioning when Layout is flowing as row. #1422

Merged
merged 9 commits into from May 27, 2021

Conversation

manuelpuyol
Copy link
Contributor

@manuelpuyol manuelpuyol commented May 25, 2021

Dividers

Dividers in the Layout component weren't correctly set when the layout was flowing as a row. Here, I extracted the flow-as-row logic to a mixing, making it also adjust the necessary gutters and sizes for dividers. I'm also adding the Layout-divider--flowRow-shallow and Layout-divider--flowRow-hidden classes that were missing.

Before After
image image

Sidebar positioning

This PR also adds the Layout--sidebarPosition-flowRow-XYZ classes, which allows the user to decide where the sidebar should be placed when the Layout is flowing as row.

image

cc @vdepizzol

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2021

🦋 Changeset detected

Latest commit: 3955254

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Not part of this PR, but I was wondering if we should use something other than border to show the containers, just in case someone thinks that's part of the component?

@manuelpuyol manuelpuyol requested a review from jonrohan May 25, 2021 22:12
@manuelpuyol
Copy link
Contributor Author

👍🏻

Not part of this PR, but I was wondering if we should use something other than border to show the containers, just in case someone thinks that's part of the component?

agree 100%! we can refactor the docs later :)

@manuelpuyol
Copy link
Contributor Author

@jonrohan @simurai I've just changed the divider class a bit if you want to take another look 3955254

@simurai simurai merged commit f780741 into main May 27, 2021
@simurai simurai deleted the layout-flow-as-row branch May 27, 2021 00:18
@primer-css primer-css mentioned this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants