Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label contrast (#1498) #1499

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Conversation

mjacobus
Copy link
Contributor

@mjacobus mjacobus commented Jul 13, 2021

Fix contrast of label, as described in #1498

If your proposal fixes any issues, please list them below, then delete this line:

Before/After
Screen Shot 2021-07-13 at 13 21 48Screen Shot 2021-07-13 at 13 20 55

/cc @primer/ds-core

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2021

🦋 Changeset detected

Latest commit: 8a0228a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis requested a review from simurai July 13, 2021 18:39
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Thank you, @mjacobus!

I'd also like to get @simurai's review on this.

src/dropdown/dropdown.scss Outdated Show resolved Hide resolved
mjacobus and others added 2 commits July 14, 2021 09:34
Co-authored-by: simurai <simulus@gmail.com>
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's get this shipped. 🚢

@simurai simurai merged commit 2e580a7 into primer:main Jul 15, 2021
@primer-css primer-css mentioned this pull request Jul 15, 2021
@mjacobus mjacobus deleted the fix-1498-fix-element-contrast branch July 15, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special labels have low contrast within a .dropdown-item:hover
3 participants