Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .text-small for de-emphasised text #152

Merged
merged 6 commits into from
Oct 19, 2015
Merged

Adding .text-small for de-emphasised text #152

merged 6 commits into from
Oct 19, 2015

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 2, 2015

This adds a small text style to be used for de-emphasized text.

For example the text under this button:

screen shot 2015-10-02 at 4 33 52 pm

@primer/owners

@aroben
Copy link

aroben commented Oct 3, 2015

This seems pretty similar to <small class="text-muted">. Would that work instead?

@jonrohan
Copy link
Member Author

jonrohan commented Oct 3, 2015

I could possibly split out the color and use text-small text-muted when I need it to be both.

@mdo
Copy link
Contributor

mdo commented Oct 4, 2015

Hmm, does the single small.text-muted work for all your instances @jonrohan? Curious if that'd be enough for us and if the implicit font-size change doesn't cause any headaches. It might be beneficial to use a relative, percent font-size for that if we don't already.

@jonrohan
Copy link
Member Author

jonrohan commented Oct 5, 2015

does the single small.text-muted work for all your instances @jonrohan?

didn't think of that, it's possible that it will work. Although some fonts might be 12px instead of 11px, I'll do some exploring and see what I can come up with. In the meantime I'll leave this open until I know if I should modify it or just use small.text-muted 👍

@jonrohan jonrohan modified the milestone: v2.4.0 Oct 13, 2015
@jonrohan jonrohan closed this Oct 19, 2015
@jonrohan jonrohan reopened this Oct 19, 2015
jonrohan added a commit that referenced this pull request Oct 19, 2015
Adding .text-small for de-emphasised text
@jonrohan jonrohan merged commit 5eec344 into master Oct 19, 2015
@jonrohan jonrohan deleted the small-note branch October 19, 2015 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants