Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V2 utilities #1580

Merged
merged 7 commits into from Sep 15, 2021
Merged

Add V2 utilities #1580

merged 7 commits into from Sep 15, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Sep 10, 2021

This adds the V2 utilities.

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2021

🦋 Changeset detected

Latest commit: 5282470

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +107 to +108
// .color-border-success { border-color: var(--color-success-emphasis) !important; }
// .color-border-danger { border-color: var(--color-danger-emphasis) !important; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These V1 class names didn't change in V2. But to satisfy the "no duplicate class names" linter rule I commented them out.

@simurai simurai marked this pull request as ready for review September 10, 2021 01:05
@simurai simurai requested a review from a team as a code owner September 10, 2021 01:05
@simurai simurai mentioned this pull request Sep 10, 2021
8 tasks
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending what the rest of the color team says, I think this looks good 👍🏻 Let's wait to hear back.

If we merge #1581 in, you can also add these classes to the deprecated list already, so we can start matching and replacing.

src/utilities/colors.scss Outdated Show resolved Hide resolved
@simurai simurai marked this pull request as draft September 14, 2021 00:59
@jonrohan
Copy link
Member

Talked this over in color modes product sync 👍🏻

@jonrohan jonrohan merged commit 4a1f09a into main Sep 15, 2021
@jonrohan jonrohan deleted the add-v2-utilities branch September 15, 2021 17:07
@primer-css primer-css mentioned this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants