Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alerts.md #1628

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Update alerts.md #1628

merged 3 commits into from
Oct 1, 2021

Conversation

edokoa
Copy link
Contributor

@edokoa edokoa commented Sep 30, 2021

Switched icons back to default icons for each type of message to avoid confusion with the presented examples, as they implied other icons could or should be used.

  • Info -> info
  • Warning -> alert
  • Error -> stop
  • Success -> check

/cc @primer/css-reviewers

Switched icons back to default icons for each type of message
* Info -> info
* Warning -> alert
* Error -> stop
* Success -> check
@edokoa edokoa requested a review from a team as a code owner September 30, 2021 11:16
@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2021

🦋 Changeset detected

Latest commit: 3c21868

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edokoa edokoa marked this pull request as draft September 30, 2021 11:16
@edokoa edokoa marked this pull request as ready for review September 30, 2021 11:17
@simurai simurai merged commit ce197c9 into main Oct 1, 2021
@simurai simurai deleted the doc-alert-fix-edokoa branch October 1, 2021 05:48
@primer-css primer-css mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants