Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed note about aria-label requiring a <button> or <a> element #168

Merged
merged 1 commit into from
Feb 16, 2016

Conversation

jdan
Copy link
Contributor

@jdan jdan commented Feb 2, 2016

aria-label can be used on any element, and is even used on the <span> example right below this paragraph.

I verified with ChromeVox+Chrome and VoiceOver+Safari that the tooltip's contents (via aria-label) are read off even on a <span>.

`aria-label` can be used on any element, and is even used on the `<span>`
example right below this paragraph.

I verified this with ChromeVox+Chrome and VoiceOver+Safari.
@mdo
Copy link
Contributor

mdo commented Feb 3, 2016

Forgot to mention in the other PR, but yeah this maps to our experience with this stuff on github/github—basically we do the same and wrap elements in <span>s when we need to.

@mdo mdo added the docs label Feb 3, 2016
@mdo mdo added this to the v2.6.0 milestone Feb 16, 2016
mdo added a commit that referenced this pull request Feb 16, 2016
Removed note about `aria-label` requiring a <button> or <a> element
@mdo mdo merged commit 6243976 into primer:master Feb 16, 2016
@jdan
Copy link
Contributor Author

jdan commented Feb 17, 2016

Thank ya 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants