Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating and autofixing stylelint #1765

Merged
merged 14 commits into from Dec 8, 2021
Merged

Updating and autofixing stylelint #1765

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a104741
Updating and autofixing stylelint
jonrohan Nov 24, 2021
3378fab
Moving config to primer/stylelint-config
jonrohan Nov 24, 2021
2a0aec3
Removing unused disables from css
jonrohan Nov 24, 2021
63fc001
Merge branch 'main' into primer-stylelint-config-12.2.0
jonrohan Dec 6, 2021
19398bf
Stylelint auto-fixes
actions-user Dec 6, 2021
01396e4
@primer/stylelint-config@12.2.0
jonrohan Dec 8, 2021
c6f4459
Remove these from workfow
jonrohan Dec 8, 2021
c825988
Use reusable release_canary workflow (#1811)
colebemis Dec 6, 2021
ae1620b
Use counter-border for LHC (#1792)
simurai Dec 7, 2021
99899dd
UnderlineNav `:focus` styles (#1764)
langermank Dec 7, 2021
4a2b293
Add note about loading the "latest" Primer CSS version (#1784)
simurai Dec 8, 2021
60a68d5
Add stashing
jonrohan Dec 8, 2021
7536bda
Stylelint auto-fixes
actions-user Dec 8, 2021
cd5e5e8
Merge branch 'main' into primer-stylelint-config-12.2.0
jonrohan Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -42,7 +42,7 @@
"@changesets/cli": "2.18.0",
"@github/prettier-config": "0.0.4",
"@koddsson/postcss-sass": "5.0.0",
"@primer/stylelint-config": "12.1.1",
"@primer/stylelint-config": "0.0.0-2021102402654",
"autoprefixer": "10.4.0",
"cssstats": "4.0.2",
"eslint": "8.3.0",
Expand Down
2 changes: 1 addition & 1 deletion src/actionlist/action-list-item.scss
View file
Open in desktop
Expand Up @@ -172,7 +172,7 @@
visibility: hidden;
opacity: 0;
transition:
visibility 0 linear $actionList-item-checkmark-transition-timing,
visibility 0 linear $actionList-item-checkmark-transition-timing,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was driving me crazy!

opacity $actionList-item-checkmark-transition-timing;
}

Expand Down
2 changes: 1 addition & 1 deletion src/autocomplete/autocomplete.scss
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@
}

&.selected,
&[aria-selected=true],
&[aria-selected='true'],
&.navigation-focus {
color: var(--color-fg-on-emphasis);
text-decoration: none;
Expand Down
1 change: 1 addition & 0 deletions src/base/base.scss
View file
Open in desktop
Expand Up @@ -46,6 +46,7 @@ hr,
background: transparent;
border: 0;
border-bottom: $border-width $border-style var(--color-border-muted);

@include clearfix();
}

Expand Down
1 change: 0 additions & 1 deletion src/base/index.scss
View file
Open in desktop
@@ -1,5 +1,4 @@
@import '../support/index.scss';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda liked that the import that doesn't output any styles is somewhat visually separated. But we can always add a comment to separate it. So the stylelint rule should still be fine to keep.

@import './normalize.scss';
@import './base.scss';
@import './kbd.scss';
Expand Down
1 change: 0 additions & 1 deletion src/blankslate/index.scss
View file
Open in desktop
@@ -1,3 +1,2 @@
@import '../support/index.scss';

@import './blankslate.scss';
2 changes: 1 addition & 1 deletion src/breadcrumb/breadcrumb.scss
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
}

.breadcrumb-item-selected,
.breadcrumb-item[aria-current]:not([aria-current=false]) {
.breadcrumb-item[aria-current]:not([aria-current='false']) {
&::after {
content: none;
}
Expand Down
5 changes: 3 additions & 2 deletions src/buttons/button-group.scss
View file
Open in desktop
Expand Up @@ -6,6 +6,7 @@
.BtnGroup {
display: inline-block;
vertical-align: middle;

@include clearfix();

// Proper spacing for multiple button groups (a la, gollum editor)
Expand Down Expand Up @@ -33,7 +34,7 @@
}

&.selected,
&[aria-selected=true],
&[aria-selected='true'],
&:focus,
&:active,
&:hover {
Expand Down Expand Up @@ -66,7 +67,7 @@
}

&.selected,
&[aria-selected=true],
&[aria-selected='true'],
&:focus,
&:active,
&:hover {
Expand Down
18 changes: 9 additions & 9 deletions src/buttons/button.scss
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@

&:disabled,
&.disabled,
&[aria-disabled=true] {
&[aria-disabled='true'] {
cursor: default;
}

Expand Down Expand Up @@ -84,14 +84,14 @@
}

&.selected,
&[aria-selected=true] {
&[aria-selected='true'] {
background-color: var(--color-btn-selected-bg);
box-shadow: var(--color-primer-shadow-inset);
}

&:disabled,
&.disabled,
&[aria-disabled=true] {
&[aria-disabled='true'] {
color: var(--color-primer-fg-disabled);
background-color: var(--color-btn-bg);
border-color: var(--color-btn-border);
Expand Down Expand Up @@ -127,14 +127,14 @@

&:active,
&.selected,
&[aria-selected=true] {
&[aria-selected='true'] {
background-color: var(--color-btn-primary-selected-bg);
box-shadow: var(--color-btn-primary-selected-shadow);
}

&:disabled,
&.disabled,
&[aria-disabled=true] {
&[aria-disabled='true'] {
color: var(--color-btn-primary-disabled-text);
background-color: var(--color-btn-primary-disabled-bg);
border-color: var(--color-btn-primary-disabled-border);
Expand Down Expand Up @@ -184,7 +184,7 @@

&:active,
&.selected,
&[aria-selected=true] {
&[aria-selected='true'] {
color: var(--color-btn-outline-selected-text);
background-color: var(--color-btn-outline-selected-bg);
border-color: var(--color-btn-outline-selected-border);
Expand All @@ -193,7 +193,7 @@

&:disabled,
&.disabled,
&[aria-disabled=true] {
&[aria-disabled='true'] {
color: var(--color-btn-outline-disabled-text);
background-color: var(--color-btn-outline-disabled-bg);
border-color: var(--color-btn-border);
Expand Down Expand Up @@ -242,7 +242,7 @@

&:active,
&.selected,
&[aria-selected=true] {
&[aria-selected='true'] {
color: var(--color-btn-danger-selected-text);
background-color: var(--color-btn-danger-selected-bg);
border-color: var(--color-btn-danger-selected-border);
Expand All @@ -251,7 +251,7 @@

&:disabled,
&.disabled,
&[aria-disabled=true] {
&[aria-disabled='true'] {
color: var(--color-btn-danger-disabled-text);
background-color: var(--color-btn-danger-disabled-bg);
border-color: var(--color-btn-border);
Expand Down
8 changes: 4 additions & 4 deletions src/buttons/misc.scss
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@
}

&:disabled,
&[aria-disabled=true] {
&[aria-disabled='true'] {
&,
&:hover {
color: var(--color-primer-fg-disabled);
Expand Down Expand Up @@ -51,7 +51,7 @@
&:active,
&:focus,
&.selected,
&[aria-selected=true],
&[aria-selected='true'],
&.zeroclipboard-is-active {
color: var(--color-accent-fg);
background: none;
Expand All @@ -62,7 +62,7 @@

&:disabled,
&.disabled,
&[aria-disabled=true] {
&[aria-disabled='true'] {
color: var(--color-primer-fg-disabled);
background-color: transparent;
}
Expand All @@ -89,7 +89,7 @@
&:hover { color: var(--color-accent-fg); }

&.disabled,
&[aria-disabled=true] {
&[aria-disabled='true'] {
color: var(--color-primer-fg-disabled);
cursor: default;

Expand Down
1 change: 1 addition & 0 deletions src/color-modes/native.scss
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@
// Enables color modes for native elements

@include color-mode(light) { color-scheme: light; }

@include color-mode(dark) { color-scheme: dark; }

[data-color-mode] {
Expand Down
1 change: 0 additions & 1 deletion src/color-modes/themes/dark.scss
View file
Open in desktop
@@ -1,5 +1,4 @@
@import '../../support/index.scss';

@import '@primer/primitives/dist/scss/colors/_dark.scss';

@include color-mode-theme(dark) {
Expand Down
1 change: 0 additions & 1 deletion src/color-modes/themes/dark_colorblind.scss
View file
Open in desktop
@@ -1,5 +1,4 @@
@import '../../support/index.scss';

@import '@primer/primitives/dist/scss/colors/_dark_colorblind.scss';

@include color-mode-theme(dark_colorblind) {
Expand Down
1 change: 0 additions & 1 deletion src/color-modes/themes/dark_dimmed.scss
View file
Open in desktop
@@ -1,5 +1,4 @@
@import '../../support/index.scss';

@import '@primer/primitives/dist/scss/colors/_dark_dimmed.scss';

@include color-mode-theme(dark_dimmed) {
Expand Down
1 change: 0 additions & 1 deletion src/color-modes/themes/dark_high_contrast.scss
View file
Open in desktop
@@ -1,5 +1,4 @@
@import '../../support/index.scss';

@import '@primer/primitives/dist/scss/colors/_dark_high_contrast.scss';

@include color-mode-theme(dark_high_contrast) {
Expand Down
1 change: 0 additions & 1 deletion src/color-modes/themes/light.scss
View file
Open in desktop
@@ -1,5 +1,4 @@
@import '../../support/index.scss';

@import '@primer/primitives/dist/scss/colors/_light.scss';

@include color-mode-theme(light, true) {
Expand Down
1 change: 0 additions & 1 deletion src/color-modes/themes/light_colorblind.scss
View file
Open in desktop
@@ -1,5 +1,4 @@
@import '../../support/index.scss';

@import '@primer/primitives/dist/scss/colors/_light_colorblind.scss';

@include color-mode-theme(light_colorblind) {
Expand Down
1 change: 0 additions & 1 deletion src/color-modes/themes/light_high_contrast.scss
View file
Open in desktop
@@ -1,5 +1,4 @@
@import '../../support/index.scss';

@import '@primer/primitives/dist/scss/colors/_light_high_contrast.scss';

@include color-mode-theme(light_high_contrast) {
Expand Down
2 changes: 2 additions & 0 deletions src/forms/form-control.scss
View file
Open in desktop
Expand Up @@ -54,6 +54,7 @@ label {
// Ensures inputs don't zoom on mobile iPhone but are body-font size on iPad
@supports (-webkit-touch-callout: none) {
font-size: $h4-size;

@include breakpoint(md) {
font-size: $body-font-size;
}
Expand Down Expand Up @@ -181,6 +182,7 @@ textarea.form-control {
.hfields {
// stylelint-disable-next-line primer/spacing
margin: 15px 0;

@include clearfix;

.form-group {
Expand Down
1 change: 0 additions & 1 deletion src/labels/index.scss
View file
Open in desktop
@@ -1,6 +1,5 @@
@import '../support/index.scss';
@import './mixins.scss';

@import './issue-labels.scss';
@import './labels.scss';
@import './states.scss';
Expand Down
1 change: 1 addition & 0 deletions src/labels/labels.scss
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@
.label, // TODO: Deprecte
.Label {
@include labels-base;

border-color: var(--color-border-default);

&:hover {
Expand Down
1 change: 0 additions & 1 deletion src/layout/index.scss
View file
Open in desktop
@@ -1,6 +1,5 @@
@import '../support/index.scss';
@import './mixins.scss';

@import './container.scss';
@import './grid.scss';
@import './grid-offset.scss';
Expand Down
1 change: 1 addition & 0 deletions src/layout/layout.scss
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@

.Layout {
display: grid;

--Layout-sidebar-width: #{map-get($sidebar-width, 'sm')};
--Layout-gutter: 16px;

Expand Down
6 changes: 3 additions & 3 deletions src/layout/mixins.scss
View file
Open in desktop
Expand Up @@ -7,9 +7,9 @@
.Layout-sidebar,
.Layout-divider,
.Layout-main {
width: 100% !important;
grid-column: 1 !important;
}
width: 100% !important;
grid-column: 1 !important;
}

&.Layout--sidebarPosition-flowRow-start {
.Layout-sidebar {
Expand Down
4 changes: 2 additions & 2 deletions src/markdown/images.scss
View file
Open in desktop
Expand Up @@ -10,12 +10,12 @@
box-sizing: content-box;
background-color: var(--color-canvas-default);

&[align=right] {
&[align='right'] {
// stylelint-disable-next-line primer/spacing
padding-left: 20px;
}

&[align=left] {
&[align='left'] {
// stylelint-disable-next-line primer/spacing
padding-right: 20px;
}
Expand Down
3 changes: 3 additions & 0 deletions src/marketing/type/typography.scss
View file
Open in desktop
Expand Up @@ -21,6 +21,7 @@

font-size: map-get($pairing, 'size') !important;
line-height: map-get($pairing, 'lh') !important;

@if (map-get($pairing, 'size') >= $mktg-header-weight-threshold) { font-weight: $mktg-header-weight-large !important; }

@if (nth($sizes, 1) != nth($sizes, 2)) {
Expand Down Expand Up @@ -75,7 +76,9 @@

font-size: map-get($pairing, 'size') !important;
line-height: map-get($pairing, 'lh') !important;

@if (map-get($pairing, 'size') >= $mktg-body-spacing-threshold) { letter-spacing: $mktg-body-spacing-large !important; }

@if (map-get($pairing, 'size') >= $mktg-body-weight-threshold) { font-weight: $font-weight-semibold; }

@if (nth($sizes, 1) != nth($sizes, 2)) {
Expand Down
4 changes: 2 additions & 2 deletions src/navigation/filter-list.scss
View file
Open in desktop
Expand Up @@ -41,8 +41,8 @@
}

&.selected,
&[aria-selected=true],
&[aria-current]:not([aria-current=false]) {
&[aria-selected='true'],
&[aria-current]:not([aria-current='false']) {
color: var(--color-fg-on-emphasis);
background-color: var(--color-accent-emphasis);
}
Expand Down
4 changes: 2 additions & 2 deletions src/navigation/menu.scss
View file
Open in desktop
Expand Up @@ -49,8 +49,8 @@
}

&.selected,
&[aria-selected=true],
&[aria-current]:not([aria-current=false]) {
&[aria-selected='true'],
&[aria-current]:not([aria-current='false']) {
cursor: default;
background-color: var(--color-menu-bg-active);

Expand Down
4 changes: 2 additions & 2 deletions src/navigation/sidenav.scss
View file
Open in desktop
Expand Up @@ -59,7 +59,7 @@
background-color: var(--color-canvas-subtle);
}

.SideNav-item[aria-current]:not([aria-current=false]),
.SideNav-item[aria-current]:not([aria-current='false']),
.SideNav-item[aria-selected='true'] {
background-color: var(--color-sidenav-selected-bg);

Expand Down Expand Up @@ -101,7 +101,7 @@
outline: none;
}

.SideNav-subItem[aria-current]:not([aria-current=false]),
.SideNav-subItem[aria-current]:not([aria-current='false']),
.SideNav-subItem[aria-selected='true'] {
font-weight: $font-weight-semibold;
color: var(--color-fg-default);
Expand Down
4 changes: 2 additions & 2 deletions src/navigation/subnav.scss
View file
Open in desktop
Expand Up @@ -40,8 +40,8 @@
}

&.selected,
&[aria-selected=true],
&[aria-current]:not([aria-current=false]) {
&[aria-selected='true'],
&[aria-current]:not([aria-current='false']) {
z-index: 2;
color: var(--color-fg-on-emphasis);
background-color: var(--color-accent-emphasis);
Expand Down
4 changes: 2 additions & 2 deletions src/navigation/tabnav.scss
View file
Open in desktop
Expand Up @@ -28,8 +28,8 @@
transition: color 0.2s cubic-bezier(0.3, 0, 0.5, 1);

&.selected,
&[aria-selected=true],
&[aria-current]:not([aria-current=false]) {
&[aria-selected='true'],
&[aria-current]:not([aria-current='false']) {
color: var(--color-fg-default);
background-color: var(--color-canvas-default); // cover bottom border
border-color: var(--color-border-default);
Expand Down