Add 2 color definitions for Windows High Contrast mode #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 341dec4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
requested changes
Jan 19, 2022
| @@ -9,3 +9,11 @@ | |||
| color: var(--color-fg-default); | |||
| background-color: var(--color-canvas-default); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Thanks for upstreaming. 🙇 Mind adding these comments here too?
Just so it's easier to remember what this does. 😃
simurai
approved these changes
Jan 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Relates to github/accessibility#373
This migrates the solution provided in https://github.com/github/github/pull/204063 to primer/css
What approach did you choose and why?
See changes and design choices made in https://github.com/github/github/pull/204063
What should reviewers focus on?
Are additional changes needed?