Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open and closed color roles #1948

Merged
merged 8 commits into from Mar 4, 2022
Merged

Add open and closed color roles #1948

merged 8 commits into from Mar 4, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Feb 22, 2022

What are you trying to accomplish?

This is part of https://github.com/github/primer/issues/725 and adds 2 new color roles (open + closed):

Screen Shot 2022-02-22 at 16 44 49

Screen Shot 2022-02-22 at 17 24 57

It also makes sure that the Open and Done states don't clash in the colorblind theme and the Closed state is more neutral like Draft:

Before After
Screen Shot 2022-03-02 at 17 28 42 Screen Shot 2022-03-02 at 17 31 10

Tasks

  • Add new utilities
  • Use new variables for State--open and State--closed
  • Add new Label--open and Label--closed variations
  • Update @primer/primitives once Add open and closed roles primitives#296 is released

What approach did you choose and why?

The new roles are needed to improve colorblind themes, see this color roles ADR.

What should reviewers focus on?

Anywhere else we could use "open/closed" colors?

Are additional changes needed?

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2022

🦋 Changeset detected

Latest commit: f8a0b2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This is just temporarily to test the docs
@simurai simurai marked this pull request as ready for review March 4, 2022 03:28
@simurai simurai requested a review from a team as a code owner March 4, 2022 03:28
@simurai simurai requested a review from jonrohan March 4, 2022 03:28
@simurai simurai merged commit 6a83a92 into main Mar 4, 2022
@simurai simurai deleted the add-open-closed-roles branch March 4, 2022 04:54
@primer-css primer-css mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant