Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input-block in form-group #1954

Merged
merged 3 commits into from Feb 28, 2022
Merged

Fix input-block in form-group #1954

merged 3 commits into from Feb 28, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Feb 25, 2022

What are you trying to accomplish?

This fixes #1951 where an input-block inside form-group would not take up full width.

Before After
Screen Shot 2022-02-25 at 14 22 55 Screen Shot 2022-02-25 at 14 24 36

What approach did you choose and why?

It seems we already account for the.long modifier. This PR does the same for .input-block.

Are additional changes needed?

  • No, this PR should be ok to ship as is. 馃殺

@simurai simurai requested a review from a team as a code owner February 25, 2022 05:45
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2022

馃 Changeset detected

Latest commit: 8f3caf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simurai simurai enabled auto-merge (squash) February 28, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.input-block inside .form-group is not 100% width
2 participants