Make pane an optional region for PageLayout component
#1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: 9c896d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
approved these changes
Mar 14, 2022
langermank
approved these changes
Mar 14, 2022
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR adds an expected functionality to PageLayout, making the
paneregion optional, and allowing single-column pages to also benefit from PageLayout's spacing structure.I've also fixed two Storybook-related issues:
What approach did you choose and why?
PageLayout has two wrapping elements:
PageLayout-wrapperandPageLayout-columns.wrappertakes care of vertical stack (header, content+pane, footer), whilecolumnshandles the horizontal the stack (content + pane).For single column layouts, I've removed
PageLayout-columnsfrom the markup, leavingcontentas a direct sibling ofheaderandfooter.Note that the
hasPaneprop from Storybook shouldn't translate 1:1 to ViewComponent or React APIs; the presence of compound components or slots should determine the region existence.What should reviewers focus on?
Are additional changes needed?