Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tritanopia theme #1997

Merged
merged 6 commits into from Apr 3, 2022
Merged

Add Tritanopia theme #1997

merged 6 commits into from Apr 3, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Mar 25, 2022

What are you trying to accomplish?

This is in support of https://github.com/github/primer/issues/844.

  • Bump primer/primitives to ^7.7.0
  • Add 2 new (light_tritanopia and dark_tritanopia) themes.
Light colorblind Light Tritanopia (✨ new)
Screen Shot 2022-03-24 at 18 23 40 Screen Shot 2022-03-24 at 18 23 55

What approach did you choose and why?

Duplicate anything with colorblind and replace it with tritanopia. For reasoning see https://github.com/github/design-infrastructure/issues/2154.

What should reviewers focus on?

Anything missing? Any concerns?

Are additional changes needed?

  • No, this PR should be ok to ship as is. 🚢

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2022

🦋 Changeset detected

Latest commit: 8cd4c6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants