Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay component #1998

Merged
merged 31 commits into from
May 10, 2022
Merged

Overlay component #1998

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
a92f659
Add styles, documentation, and storybook story for the new dialog com…
Mar 25, 2022
013904b
Stylelint auto-fixes
actions-user Mar 25, 2022
a2ac939
Create slow-poets-mate.md
langermank Mar 30, 2022
00b8195
Update slow-poets-mate.md
langermank Mar 30, 2022
8603de5
update namespace
langermank Apr 14, 2022
f009094
Stylelint auto-fixes
actions-user Apr 14, 2022
5c1a056
menu specifics
langermank Apr 19, 2022
e38373c
starting over
langermank Apr 22, 2022
bd44e26
a new paradigm
langermank Apr 22, 2022
9f446cd
fully responsive
langermank Apr 22, 2022
fa39835
push for testing
langermank Apr 22, 2022
33a4670
auto width, visibility hidden
langermank Apr 25, 2022
c061401
Overlay stories
langermank Apr 26, 2022
06a2254
dialog stories
langermank Apr 26, 2022
f8c787f
Merge branch 'main' into accessibility/issues/925/dialog-component
langermank Apr 26, 2022
10345a3
cleanup
langermank Apr 26, 2022
2dcdfda
Merge branch 'accessibility/issues/925/dialog-component' of https://g…
langermank Apr 26, 2022
8007f19
remove popover
langermank Apr 26, 2022
8dd553e
remove unused import
langermank Apr 26, 2022
4b9270e
docs update
langermank Apr 26, 2022
81d3bb2
min() to the rescue!
langermank Apr 26, 2022
e0a3bf5
thin scrollbar?
langermank Apr 26, 2022
80a021f
remove comment
langermank Apr 27, 2022
878d6d7
Update src/overlay/overlay.scss
langermank Apr 27, 2022
35730cf
address feedback
langermank Apr 27, 2022
a58a244
Merge branch 'accessibility/issues/925/dialog-component' of https://g…
langermank Apr 27, 2022
2257246
handle form elements
langermank May 4, 2022
ada0d64
test permissions
langermank May 4, 2022
b94a0b8
Merge branch 'main' into accessibility/issues/925/dialog-component
langermank May 10, 2022
b9747f7
lint
langermank May 10, 2022
ea44985
Merge branch 'accessibility/issues/925/dialog-component' of https://g…
langermank May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/overlay/overlay.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ $primer-borderRadius-large: 0.75rem;
padding-bottom: $spacer-2;
// stylelint-disable-next-line primer/box-shadow
box-shadow: inset 0 #{-$border-width} var(--color-border-default);

+ .Overlay-body {
padding-top: $spacer-3;
}
}

&.Overlay-header--large {
Expand Down Expand Up @@ -154,12 +158,15 @@ $primer-borderRadius-large: 0.75rem;
// generic body content slot
.Overlay-body {
padding: $spacer-3;
vdepizzol marked this conversation as resolved.
Show resolved Hide resolved
overflow-y: auto;
padding-top: 0;
overflow-y: scroll;
langermank marked this conversation as resolved.
Show resolved Hide resolved
scrollbar-width: thin;
Copy link
Contributor

@vdepizzol vdepizzol Apr 27, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy! :chef-kiss:

font-size: $body-font-size;
flex-grow: 1;

&.Overlay-body--paddingCondensed {
padding: $spacer-2;
padding-top: 0;
}

&.Overlay-body--paddingNone {
Expand Down