Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .text-capitalize utility class #2072

Merged
merged 3 commits into from May 4, 2022
Merged

Add .text-capitalize utility class #2072

merged 3 commits into from May 4, 2022

Conversation

JasonEtco
Copy link
Contributor

What are you trying to accomplish?

Adds the .text-capitalize utility class!

What approach did you choose and why?

There are some cases where capitalizing text just can't be done in its initial rendering (ex: on the server), so CSS text transformation becomes the easiest approach. This PR adds the .text-capitalize class - similar to text-uppercase et al, it sets text-transform: capitalize.

What should reviewers focus on?

Nothing!

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 馃殺

@JasonEtco JasonEtco requested a review from a team as a code owner May 4, 2022 19:05
@JasonEtco JasonEtco requested a review from simurai May 4, 2022 19:05
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2022

馃 Changeset detected

Latest commit: 6255f5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan merged commit ab6f084 into main May 4, 2022
@jonrohan jonrohan deleted the text-capitalize branch May 4, 2022 19:17
@primer-css primer-css mentioned this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants