Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-selected to ActionList-item for Autocomplete #2176

Merged
merged 5 commits into from Jul 28, 2022

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jul 27, 2022

What are you trying to accomplish?

Quick patch to use the navActive state for aria-selected in the case of Autocomplete items.

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@langermank langermank requested a review from a team as a code owner July 27, 2022 23:24
@langermank langermank requested a review from simurai July 27, 2022 23:24
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2022

🦋 Changeset detected

Latest commit: c9893c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to Storybook Preview July 27, 2022 23:30 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview July 27, 2022 23:30 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview July 27, 2022 23:33 Inactive
@langermank langermank merged commit d8c218a into main Jul 28, 2022
@langermank langermank deleted the actionlist-autocomplete-selected branch July 28, 2022 00:20
@primer-css primer-css mentioned this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants