Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline code collapsing spaces #2330

Merged
merged 3 commits into from Nov 30, 2022
Merged

Fix inline code collapsing spaces #2330

merged 3 commits into from Nov 30, 2022

Conversation

stevenlaidlaw
Copy link
Contributor

What are you trying to accomplish?

Prevent spaces from collapsing within inline code blocks.

What approach did you choose and why?

Added a CSS rule to prevent this from happening. The break-spaces value was chosen to allow the content to wrap correctly if many spaces are used within the line.

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2022

🦋 Changeset detected

Latest commit: 43b2b39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 🙇

@simurai simurai enabled auto-merge (squash) November 30, 2022 01:49
@simurai simurai merged commit 83250f8 into primer:main Nov 30, 2022
@primer-css primer-css mentioned this pull request Nov 30, 2022
@stevenlaidlaw stevenlaidlaw deleted the fix-inline-code-collapsing-spaces branch November 30, 2022 02:42
@simurai simurai mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants