Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to Primer View Components v0.0.117 #2351

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Dec 29, 2022

What are you trying to accomplish?

This upgrades to primer view components 0.0.117 https://github.com/primer/view_components/releases/tag/v0.0.117

That release includes a revert to remove the :is( autocompiling that happens in postcss. And there are a few import names that changed.

Closes #2349

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@jonrohan jonrohan requested a review from a team as a code owner December 29, 2022 18:57
@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022

🦋 Changeset detected

Latest commit: d17f68a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to Storybook Preview December 29, 2022 19:03 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview December 29, 2022 19:04 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview December 29, 2022 19:07 Inactive
@jonrohan jonrohan changed the title Updating to primer view components 0.0.117 Updating to Primer View Components v0.0.117 Dec 29, 2022
@jonrohan jonrohan enabled auto-merge (squash) December 29, 2022 19:10
color: inherit !important;
}
}
@import '@primer/view-components/app/components/primer/beta/link';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. ✨

@jonrohan jonrohan merged commit 1b6694c into main Dec 30, 2022
@jonrohan jonrohan deleted the primer_view_components_117 branch December 30, 2022 03:05
@primer-css primer-css mentioned this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump @primer/css from 20.7.1 to 20.8.0 causing issues with postcss-is-pseudo-class
2 participants