Trigger canary release on successful PR build #246
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,13 @@ | ||
| language: node_js | ||
| node_js: | ||
| - 7 | ||
|
|
||
| before_script: | ||
| - npm config set "//registry.npmjs.org/:_authToken=\${NPM_API_KEY}" | ||
| - lerna bootstrap | ||
|
|
||
| script: | ||
| - npm test | ||
|
|
||
| after_success: | ||
| - script/cibuild --yes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #!/bin/bash | ||
| set -e | ||
|
|
||
| # --yes gets passed in by .travis.yml, | ||
| # which makes this easier to test locally | ||
| args=${@:1} | ||
|
|
||
| # always publish a canary release if this is a PR build | ||
| if [[ $TRAVIS_EVENT_TYPE = pull_request ]]; then | ||
| echo "🐦 Publishing canary version..." | ||
| npm run release-canary -- ${args} | ||
| # merges to dev build a release candidate | ||
| elif [[ $TRAVIS_BRANCH = dev ]]; then | ||
| echo "👌 Publishing release candidate..." | ||
| echo npm run release-candidate -- ${args} | ||
|
There was a problem hiding this comment. Note the |
||
| # publish a release when we merge to master | ||
| elif [[ $TRAVIS_BRANCH = master ]]; then | ||
| echo "📦 Publishing latest release!" | ||
| echo npm run release -- ${args} | ||
| else | ||
| echo "⚠️ This isn't a PR and '${TRAVIS_BRANCH}' isn't a release branch." | ||
| exit 1 | ||
| fi | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #!/bin/bash | ||
| set -e | ||
|
|
||
| # reads the tag either from $NPM_TAG or first positional arg: | ||
| # script/compare-published [tag] | ||
| tag=${1:-${NPM_TAG:-latest}} | ||
|
|
||
| # this is way faster than `lerna exec npm info . .name` | ||
| # (but will skip modules that don't have "primer-" in them) | ||
| modules=`ls -1 modules | egrep primer-` | ||
|
|
||
| # tabular output separator for column(1) | ||
| s=, | ||
|
|
||
| echo "📦 Comparing Primer modules published @${tag}..." | ||
| ( | ||
| echo "module${s}tag${s}published${s}local" | ||
| for module in $modules; do | ||
| v_published=`npm info ${module}@${tag} .version` | ||
| v_local=`jq -Mr .version modules/${module}/package.json` | ||
| echo "${module}${s}${tag}${s}${v_published:-x}${s}${v_local}" | ||
| done | ||
| ) | column -t -s=${s} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So a release will be
lerna publish --yesHow does that resolve versions?
e.g.
If you merged changes to master that constitute a minor bump of:
a@1.1.0toa@1.2.0b@2.0.0to becomeb@2.0.1c@3.0.0to becomec@3.0.1and a major of:
d@4.0.0tod@5.0.0as well as a small change of:
c@3.0.0toc@3.0.1How would that all get resolved non interactively?
The result needs to be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for weighing in, @bradbarrow. My hope – perhaps based on bad assumptions, which I'm more than happy to reassess – was that we could do the version resolution with
lerna publish --no-npmand file a PR with the resulting versions, then have those versions published without any incrementing or prompting when the PR merges. I haven't tested this out yet, but I plan to today.