Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release primer-css@9.1.0 #258

Merged
merged 120 commits into from Jul 24, 2017
Merged

Release primer-css@9.1.0 #258

merged 120 commits into from Jul 24, 2017

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Jul 20, 2017

This is our release branch for v9.1.0 of primer-css, and minor version bumps of all the other submodules.

Changes

TODO

  • Make sure that the RC auto-publishing works the first time around.
  • Make sure that the next RC version is published when we push commits.
  • Update the change log.
  • Because this branch contains additional changes to the CI script, we'll need to merge master back into dev after merging this.

@shawnbot
Copy link
Contributor Author

Hmm, it's weird that there's a commit status hanging around from (merge commit) 71aa389:

image

@shawnbot
Copy link
Contributor Author

I was struggling to get the detection of the release branch to work. (Turns out, when you're testing regular expressions in bash you shouldn't quote the regex!) 🤞 This next commit will trigger a release candidate, and not a PR release.

@shawnbot
Copy link
Contributor Author

Well, the push build failed because I wasn't setting the branch variable correctly, and the last couple of PR builds dumped core during lerna bootstrap. We'll see...

@shawnbot
Copy link
Contributor Author

Oh hey, it worked!

image

@shawnbot
Copy link
Contributor Author

If anyone's interested, you can see the output from script/cibuild in both the PR build (which doesn't do anything) and the push build (which publishes). I'm on the fence about this distinction, and wonder whether we even really need the separate PR builds on Travis.

@shawnbot shawnbot changed the title [WIP] Release primer-css@9.1.0 Release primer-css@9.1.0 Jul 24, 2017
Copy link
Member

@broccolini broccolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shawnbot shawnbot merged commit 16de342 into master Jul 24, 2017
@shawnbot shawnbot deleted the release-9.1.0 branch July 24, 2017 21:02
@shawnbot shawnbot mentioned this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants