Deprecated gradient mixin #27
Conversation
| @@ -10,7 +10,8 @@ | |||
| white-space: nowrap; | |||
| vertical-align: middle; | |||
| cursor: pointer; | |||
| @include gradient(#fcfcfc, #eee); | |||
| background-color: #eee; | |||
There was a problem hiding this comment.
Color literals like #eee should only be used in variable declarations; they should be referred to via variable everywhere else.
|
Apologies for the color literals errors—I've updated our Hound config to ignore them. Small typo in your commit message and issue title though—you want deprecated, but you've used depreciated. If you could, please change it and push again? <3 |
iamphill
force-pushed
the
remove-gradient-mixin
branch
from
6f06ea9
to
f695871
Compare
|
@mdo Wow that was bad a mistake... Fixed 👍 also, glad you mentioned it was an issue with Hound. I was going to spend time putting the colours into vars... |
iamphill
force-pushed
the
remove-gradient-mixin
branch
from
f695871
to
feee0df
Compare
|
Howdy—thanks for the pull request, @iamphill! Before we can merge your changes, we need you to review our Contributor License Agreement (CLA). We think of CLAs as an open source software license between you and the project, letting us and other users know that we have permission to use the code you contribute. At the bottom of the pull request, you'll see the note about a failed test. Just click the Details link, review the CLA, and sign off at the bottom. Questions? Just holler—I'm here to help :). <3 |
iamphill
force-pushed
the
remove-gradient-mixin
branch
from
feee0df
to
aedc4a1
Compare
|
Rebased with upstream ❤️ |
|
Thanks! |
Fix drop shadow in Atom illo
Kept the mixin but added in a warning.