Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point style field to build file in subhead component #416

Merged
merged 2 commits into from
Jan 6, 2018

Conversation

muan
Copy link
Contributor

@muan muan commented Jan 3, 2018

Similar to #394. I noticed this one still has an old style field.

cc @primer/design-systems

@broccolini
Copy link
Member

Thanks @muan, sorry we missed that.

FYI I think the test is failing because we added a test to check the license has the current year (and it's still on 2017), we'll need to fix that for all the packages before any of the tests will pass 😆. We have a couple of other small updates to do so can pull this into a small release shortly.

@broccolini broccolini added this to Release backlog in 📦 Primer CSS release tracking via automation Jan 3, 2018
@broccolini broccolini moved this from Release backlog to 🙋 10.3.0 To do in 📦 Primer CSS release tracking Jan 3, 2018
@broccolini broccolini mentioned this pull request Jan 3, 2018
17 tasks
@jonrohan jonrohan changed the base branch from dev to release-10.3.0 January 5, 2018 02:19
Copy link
Member

@broccolini broccolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM so I'm going to merge into the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants