Fix markdown stories #464
Merged
Fix markdown stories #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
approved these changes
Mar 27, 2018
| .map(parseBlockAttrs) | ||
| .filter(({block}) => block.story !== "false") | ||
| .map(node => { | ||
| return nodeToStory(node, path) |
There was a problem hiding this comment.
Nit: could technically be on the same line
.map(node => nodeToStory(node, path))There was a problem hiding this comment.
Yup, good catch. Pretty sure I was doing something else in this function earlier. 😊
jonrohan
approved these changes
Mar 27, 2018
| loader: 'raw-loader', | ||
| }) | ||
| } | ||
| }) |
There was a problem hiding this comment.
Don't know if this is common practice in webpack config, but I would feel better if eventually we used the standard loaders, maybe enhancing with extra webpack stuff. 🤷♂️
There was a problem hiding this comment.
Yep, it's definitely a hack!
This was referenced Dec 15, 2022
This was referenced Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463. This commit hosed our markdown parsing by adding a markdown preprocessor to Storybook, which prevented us from parsing the markdown files as raw markdown.
Also, single quotes are better than double?
/cc @primer/ds-core