Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add text underline utility & correct relative comment #548

Merged
merged 3 commits into from
Jul 27, 2018
Merged

add text underline utility & correct relative comment #548

merged 3 commits into from
Jul 27, 2018

Conversation

pqt
Copy link
Contributor

@pqt pqt commented Jul 25, 2018

Adds a utility class for .text-underline and adjusts the corresponding comment

Fixes: #540

/cc @primer/ds-core

@shawnbot shawnbot changed the base branch from master to release-10.8.0 July 26, 2018 21:52
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @austinpaquette!

@shawnbot
Copy link
Contributor

Actually, one thing before we merge this: @austinpaquette, could you add an example of this in the docs?

@pqt
Copy link
Contributor Author

pqt commented Jul 26, 2018

On it. @shawnbot

@pqt
Copy link
Contributor Author

pqt commented Jul 26, 2018

All done, first time I've built the primer storybook on my machine. My primer contributor status is evolving.

@emplums
Copy link
Contributor

emplums commented Jul 27, 2018

🙌 Thanks @austinpaquette! Going to merge in for our next minor release :)

@emplums emplums merged commit 5bcd023 into primer:release-10.8.0 Jul 27, 2018
@emplums emplums mentioned this pull request Jul 27, 2018
15 tasks
@pqt
Copy link
Contributor Author

pqt commented Jul 27, 2018

My pleasure. I no longer use primer but I love what y'all have put together so just happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants