Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve contributing docs and add DEVELOP.md #585

Merged
merged 10 commits into from
Oct 23, 2018
Merged

Improve contributing docs and add DEVELOP.md #585

merged 10 commits into from
Oct 23, 2018

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Oct 18, 2018 •
edited

This moves some of our development, releasing, and more general contributing docs around. The links below will take you to the rendered docs in this branch:

  1. Release docs were duplicated in ./github/CONTRIBUTING.md, and have been moved and linked to in RELEASING.md.
  2. The out-of-date "Build" section in README.md has been removed, and replaced with a link to the new DEVELOP.md.

I made some other changes along the way:

  • Add instructions for fixing npm and/or package-lock installation issues
  • Fix formatting of PR template markdown
  • Remove the github/github installation step for stylelint-config-primer

@shawnbot shawnbot added Tag: Documentation 💓collab a vibrant hub of collaboration labels Oct 18, 2018
@shawnbot shawnbot changed the title [WIP] Contributing doc updates Contributing doc updates Oct 18, 2018
@shawnbot shawnbot added this to v10.9.0 Release in 📦 Primer CSS release tracking Oct 22, 2018
@shawnbot shawnbot mentioned this pull request Oct 22, 2018
Merged
19 tasks
@shawnbot shawnbot moved this from v10.9.0 Release to v10.10.0 Release in 📦 Primer CSS release tracking Oct 22, 2018
@shawnbot shawnbot changed the base branch from release-10.9.0 to release-10.10.0 October 22, 2018 23:25
emplums
emplums approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shawnbot shawnbot changed the title Contributing doc updates Improve contributing docs and add DEVELOP.md Oct 23, 2018
@shawnbot shawnbot merged commit aa511bd into release-10.10.0 Oct 23, 2018
📦 Primer CSS release tracking automation moved this from v10.10.0 Release to 💜 Done Oct 23, 2018
@shawnbot shawnbot deleted the contrib-tweaks branch October 23, 2018 21:21
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
@github-actions github-actions bot mentioned this pull request Dec 19, 2022
Open
This was referenced Jan 1, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emplums emplums emplums approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees
No one assigned
Labels
💓collab a vibrant hub of collaboration Tag: Documentation
Projects
No open projects
📦 Primer CSS release tracking
💜 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shawnbot @emplums